Skip to content

cann : fix ops broken by circular padding guard - #17825

Merged
CISC merged 1 commit into
masterfrom
cisc/cann-fix-broken-ops
Dec 12, 2025
Merged

cann : fix ops broken by circular padding guard#17825
CISC merged 1 commit into
masterfrom
cisc/cann-fix-broken-ops

Conversation

@CISC

@CISC CISC commented Dec 6, 2025

Copy link
Copy Markdown
Member

Fix ops inadvertently broken by #16985, sorry about that.

@CISC
CISC requested a review from hipudding December 6, 2025 15:37
@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning Ascend NPU issues specific to Ascend NPUs labels Dec 6, 2025
@CISC

CISC commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

@hipudding gentle ping

@CISC
CISC requested a review from taronaeo December 12, 2025 13:59
@CISC

CISC commented Dec 12, 2025

Copy link
Copy Markdown
Member Author

@taronaeo Since you commented on the other CANN PR and @hipudding is busy, let's get this in before that. :)

@taronaeo taronaeo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@CISC
CISC merged commit dcb7d17 into master Dec 12, 2025
77 of 78 checks passed
@CISC
CISC deleted the cisc/cann-fix-broken-ops branch December 12, 2025 14:49
@hipudding

Copy link
Copy Markdown
Contributor

Thanks for your fix.

Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
MrLordCat referenced this pull request in MrLordCat/llama.cpp-with-GUI Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ascend NPU issues specific to Ascend NPUs ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants