Skip to content

cuda/vulkan : bicubic interpolation - #17022

Merged
CISC merged 4 commits into
ggml-org:masterfrom
Acly:vulkan-bicubic
Nov 10, 2025
Merged

cuda/vulkan : bicubic interpolation#17022
CISC merged 4 commits into
ggml-org:masterfrom
Acly:vulkan-bicubic

Conversation

@Acly

@Acly Acly commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator

Backend support for GGML_OP_UPSCALE with GGML_SCALE_MODE_BICUBIC

  • CUDA: implemented
  • Vulkan: implemented
  • OpenCL: adjusted ggml_backend_supports_op to return false for bicubic

Combined PR so I can add backend-ops tests without having them fail for some backends.

@github-actions github-actions Bot added testing Everything test related Nvidia GPU Issues specific to Nvidia GPUs Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning OpenCL Issues specific to the OpenCL backend labels Nov 5, 2025
@lhez

lhez commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Thank you, looks good for OpenCL.

0cc4m
0cc4m approved these changes Nov 8, 2025
View reviewed changes

@0cc4m 0cc4m left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Vulkan code is fine.

slaren
slaren approved these changes Nov 8, 2025
View reviewed changes
Comment thread tests/test-backend-ops.cpp Outdated
CISC
CISC reviewed Nov 8, 2025
View reviewed changes
Comment thread ggml/src/ggml-vulkan/ggml-vulkan.cpp Outdated
@Acly
tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend …
df34fda 
…tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail
@Acly

Acly commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator Author

Fixed the whitespace issues. Also did a rebase, which should fix the test-thread-safety issue from last CI run.

@DajanaV DajanaV mentioned this pull request Nov 8, 2025
Closed
CISC
CISC reviewed Nov 9, 2025
View reviewed changes
Comment thread tests/test-backend-ops.cpp Outdated
@CISC
CISC merged commit 1032256 into ggml-org:master Nov 10, 2025
71 checks passed
@bluebread bluebread mentioned this pull request Nov 30, 2025
Merged
Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
@Anico2
cuda/vulkan : bicubic interpolation (ggml-org#17022)
bbfda1d 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
@Acly shaobo.xie
cuda/vulkan : bicubic interpolation (#17022)
951fa5b 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
@SamuelOliveirads SamuelOliveirads mentioned this pull request Feb 17, 2026
Merged
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
@Acly
cuda/vulkan : bicubic interpolation (ggml-org#17022)
fedd492 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
@Acly
cuda/vulkan : bicubic interpolation (ggml-org#17022)
2c5fa7d 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
@Acly
cuda/vulkan : bicubic interpolation (ggml-org#17022)
1aa97c9 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
@Acly
cuda/vulkan : bicubic interpolation (ggml-org#17022)
2d57fc3 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
@Acly
cuda/vulkan : bicubic interpolation (ggml-org#17022)
25145c9 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
@Acly
cuda/vulkan : bicubic interpolation (ggml-org#17022)
be36551 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
@Acly
cuda/vulkan : bicubic interpolation (ggml-org#17022)
9f8514f 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
MrLordCat referenced this pull request in MrLordCat/llama.cpp-with-GUI Jul 16, 2026
@Acly
cuda/vulkan : bicubic interpolation (#17022)
0c77e46 
* vulkan : implement upscale with bicubic interpolation

* cuda : implement upscale with bicubic interpolation

* tests : add ggml_interpolate with GGML_SCALE_MODE_BICUBIC to backend tests

* adapt OpenCL backend to not support the OP in that case so tests don't fail

* print scale mode & flags in test-backend-ops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC approved these changes
@slaren slaren slaren approved these changes
@0cc4m 0cc4m 0cc4m approved these changes
@lhez lhez Awaiting requested review from lhez
@max-krasnyansky max-krasnyansky Awaiting requested review from max-krasnyansky

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs OpenCL Issues specific to the OpenCL backend testing Everything test related Vulkan Issues specific to the Vulkan backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Acly @lhez @CISC @slaren @0cc4m