You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had intended to modify convert_hf_to_gguf_update.py with stockmark, as was indicated by #6920 (which was output by the main convert_hf_to_gguf.py script)
Once the line was added and convert_hf_to_gguf_update.py was run, I was able to successfully convert the stockmark2-100b safetensors to gguf q8_0.
Was extension for support of new BPE tokenizers not the intention of the script?
I had intended to modify convert_hf_to_gguf_update.py with stockmark, as was indicated by #6920 (which was output by the main convert_hf_to_gguf.py script) Once the line was added and convert_hf_to_gguf_update.py was run, I was able to successfully convert the stockmark2-100b safetensors to gguf q8_0.
You may have been able to convert it, but it won't run as you've then added the new stockfish2 pre-tokenizer value, but none of the code to support it. You need to figure out if the pre-tokenizer (in tokenizer.json) uses a new regex or an already supported one, and what settings to use (mainly clean_spaces (clean_up_tokenization_spaces from tokenizer_config.json)). This all needs to be added in llama-vocab.cpp (look for LLAMA_VOCAB_PRE_TYPE_).
Once that is done you should be able to run the test-tokenizer-0 test with the files generated by convert_hf_to_gguf_update.py to verify the tokenizer.
You also need to commit convert_hf_to_gguf.py that was updated by convert_hf_to_gguf_update.py with the new hash.
Was extension for support of new BPE tokenizers not the intention of the script?
Yes, but a little more work is required. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Stockmark.
I tested conversion script before/after PR to verify correctness.
Make sure to read the contributing guidelines before submitting a PR