Skip to content

build(test-multiprocessing): Migrate to uv and pyproject.toml #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 1 commit into from
May 21, 2026
Merged

build(test-multiprocessing): Migrate to uv and pyproject.toml #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test-multiprocessing/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[project]
name = "test-multiprocessing"
version = "0"
requires-python = ">=3.12"

@sentry sentry Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The pyproject.toml requires Python >=3.12, but the .python-version file is pinned to 3.9, causing uv run to fail.
Severity: HIGH

Suggested Fix

Align the Python versions. Either update the .python-version file to a version that satisfies >=3.12 (e.g., 3.12), or adjust the requires-python constraint in pyproject.toml to be compatible with 3.9 (e.g., >=3.9).

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: test-multiprocessing/pyproject.toml#L4

Potential issue: The `pyproject.toml` file specifies a `requires-python` constraint of
`>=3.12`. However, the `.python-version` file in the same directory pins the Python
version to `3.9`. When `uv run python main.py` is executed, `uv` detects this version
incompatibility between the project's requirement and the specified local version,
leading to an error and failure of the command.

Did we get this right? 👍 / 👎 to inform future reviews.


dependencies = [
"ipdb>=0.13.13",
"sentry-sdk",
]

[tool.uv.sources]
sentry-sdk = { path = "../../sentry-python", editable = true }
5 changes: 0 additions & 5 deletions test-multiprocessing/requirements.txt
View file
Open in desktop

This file was deleted.

11 changes: 4 additions & 7 deletions test-multiprocessing/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
#!/usr/bin/env bash

set -euo pipefail

reset

python -m venv .venv
source .venv/bin/activate

pip install -r requirements.txt
if ! command -v uv &> /dev/null; then
curl -LsSf https://astral.sh/uv/install.sh | sh
fi

python main.py
uv run python main.py
Comment on lines +5 to +9

@sentry sentry Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The run.sh script installs uv but fails to use it immediately after, as the PATH is not updated in the current shell session.
Severity: HIGH

Suggested Fix

After installing uv, update the PATH in the current shell session before calling uv run. For example, add export PATH="$HOME/.cargo/bin:$PATH" or a similar command appropriate for the uv installation path.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: test-multiprocessing/run.sh#L5-L9

Potential issue: In an environment where `uv` is not pre-installed, the `run.sh` script
attempts to install it. However, the installation script only modifies shell profile
files (e.g., `.bashrc`) and does not update the `PATH` for the current, non-interactive
shell session. Because the script immediately calls `uv run` and uses `set -e`, the
execution halts with a "command not found" error, preventing the script from completing.

Did we get this right? 👍 / 👎 to inform future reviews.

Loading