Skip to content

build(test-llm-manual-instrumentation): Migrate to uv and pyproject.toml #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 1 commit into from
May 21, 2026
Merged

build(test-llm-manual-instrumentation): Migrate to uv and pyproject.toml #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test-llm-manual-instrumentation/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[project]
name = "test-llm-manual-instrumentation"
version = "0"
requires-python = ">=3.12"

@sentry sentry Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The pyproject.toml requires Python >=3.12, but the .python-version file pins 3.10.4, which will cause uv to fail due to a version mismatch.
Severity: HIGH

Suggested Fix

Align the Python version requirements across the project. Either update the .python-version file to a version that is >=3.12, or adjust the requires-python constraint in pyproject.toml to be compatible with 3.10.4.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: test-llm-manual-instrumentation/pyproject.toml#L4

Potential issue: The newly added `pyproject.toml` file specifies a Python version
requirement of `requires-python = ">=3.12"`. However, the pre-existing `.python-version`
file in the repository pins the Python version to `3.10.4`. When `uv run` is executed,
it enforces version compatibility and will fail because the pinned version (`3.10.4`)
does not satisfy the new requirement. This conflict will prevent the test from running
in any environment that respects the `.python-version` file.

Did we get this right? 👍 / 👎 to inform future reviews.


dependencies = [
"ipdb>=0.13.13",
"sentry-sdk",
]

[tool.uv.sources]
sentry-sdk = { path = "../../sentry-python", editable = true }
4 changes: 0 additions & 4 deletions test-llm-manual-instrumentation/requirements.txt
View file
Open in desktop

This file was deleted.

11 changes: 4 additions & 7 deletions test-llm-manual-instrumentation/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
#!/usr/bin/env bash

set -euo pipefail

reset

python -m venv .venv
source .venv/bin/activate

pip install -r requirements.txt
if ! command -v uv &> /dev/null; then
curl -LsSf https://astral.sh/uv/install.sh | sh
fi

python main.py
uv run python main.py
Comment on lines +5 to +9

@sentry sentry Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The uv installer doesn't update the PATH for the current shell, causing the subsequent uv run command to fail with "command not found".
Severity: HIGH

Suggested Fix

After the uv installation command, source the appropriate environment file to update the PATH for the current session. For example, add source "$HOME/.cargo/env" immediately after the curl ... | sh line.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: test-llm-manual-instrumentation/run.sh#L5-L9

Potential issue: The `run.sh` script installs `uv` using `curl ... | sh`. This
installation method modifies shell configuration files for future sessions but does not
add the `uv` executable to the `PATH` of the current shell session. Consequently, the
subsequent call to `uv run python main.py` fails with a "command not found" error.
Because the script is configured with `set -euo pipefail`, this error will cause the
script to exit immediately, preventing the test from running on any machine where `uv`
is not already installed.

Did we get this right? 👍 / 👎 to inform future reviews.

Loading