build(test-flask-otel): Migrate to uv and pyproject.toml#27
Conversation
Replace pip/requirements.txt with uv/pyproject.toml for dependency management. Update run.sh to use uv run instead of manual venv creation and pip install. Refs PY-2454 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9e4991d. Configure here.
|
|
||
| # Run Flask application on localhost:5000 | ||
| flask --app app run No newline at end of file | ||
| uv run flask --app app run |
There was a problem hiding this comment.
uv missing after installer subshell
Medium Severity
When uv is not on PATH, run.sh installs it via curl … | sh, then immediately runs uv run. The installer runs in a subshell and does not update the parent shell’s PATH, so the next line often fails with “command not found” on a fresh machine unless ~/.local/bin was already configured.
Reviewed by Cursor Bugbot for commit 9e4991d. Configure here.
| if ! command -v uv &> /dev/null; then | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| fi | ||
|
|
||
| # create and activate virtual environment | ||
| python -m venv .venv | ||
| source .venv/bin/activate | ||
|
|
||
| # Install (or update) requirements | ||
| python -m pip install -r requirements.txt | ||
|
|
||
| # Run Flask application on localhost:5000 | ||
| flask --app app run No newline at end of file | ||
| uv run flask --app app run |
There was a problem hiding this comment.
Bug: The script calls uv run immediately after installing uv, but the executable's path is not added to the current shell's $PATH, causing a "command not found" error.
Severity: HIGH
Suggested Fix
After the uv installation line, explicitly add the installation directory to the $PATH for the current script session, for example: export PATH="$HOME/.local/bin:$PATH". This ensures the uv command is available for subsequent steps.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: test-flask-otel/run.sh#L4-L8
Potential issue: The script installs `uv` using `curl -LsSf
https://astral.sh/uv/install.sh | sh`. This installer places the `uv` binary in a
directory like `~/.local/bin` and updates shell profile files, but these changes do not
apply to the currently running script's environment. Consequently, the subsequent call
to `uv run` fails because the shell cannot find the `uv` executable in its `$PATH`.
Since the script is configured with `set -euo pipefail`, this failure will cause the
script to exit prematurely.
Did we get this right? 👍 / 👎 to inform future reviews.
Summary
pip/requirements.txtwithuv/pyproject.tomlfor dependency managementrun.shto useuv runinstead of manual venv creation and pip installrequirements.txtRefs PY-2454
Test plan
pyproject.tomlincludes all dependencies from the originalrequirements.txtrun.shusesuv runrequirements.txtis removed🤖 Generated with Claude Code