build(test-fastapi-root-path): Migrate to uv and pyproject.toml#24
Merged
Conversation
Replace pip/requirements.txt with uv/pyproject.toml for dependency management. Update run.sh to use uv run instead of manual venv creation and pip install. Refs PY-2451 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment on lines
+5
to
+9
| if ! command -v uv &> /dev/null; then | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| fi | ||
|
|
||
| #nginx -c "$(pwd)/nginx.conf" | ||
| uv run uvicorn main:app --port 5000 --reload |
There was a problem hiding this comment.
Bug: The script installs uv in a subshell, which doesn't update the parent shell's PATH. The subsequent uv command fails with "command not found".
Severity: MEDIUM
Suggested Fix
Source the installer script instead of piping it to a new shell, for example: source <(curl -LsSf https://astral.sh/uv/install.sh). This will run the installer in the current shell process, allowing it to modify the PATH environment variable. Alternatively, explicitly add the installation directory (e.g., $HOME/.cargo/bin) to the PATH after the installation step.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: test-fastapi-root-path/run.sh#L5-L9
Potential issue: The `run.sh` script attempts to install `uv` using `curl -LsSf
https://astral.sh/uv/install.sh | sh`. This command runs the installer in a subshell,
which prevents it from modifying the `PATH` environment variable of the main script's
process. Consequently, the next command, `uv run ...`, fails because the shell cannot
find the `uv` executable. Since the script is configured with `set -euo pipefail`, this
"command not found" error will cause the script to terminate, failing the test for any
environment where `uv` is not pre-installed.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip/requirements.txtwithuv/pyproject.tomlfor dependency managementrun.shto useuv runinstead of manual venv creation and pip installrequirements.txtRefs PY-2451
Test plan
pyproject.tomlincludes all dependencies from the originalrequirements.txtrun.shusesuv runrequirements.txtis removed🤖 Generated with Claude Code