build(test-fastapi-distributed-tracing): Migrate to uv and pyproject.toml#22
Merged
Merged
Conversation
…toml Replace pip/requirements.txt with uv/pyproject.toml for dependency management. Update run1.sh and run2.sh to use uv run instead of manual venv creation and pip install. Refs PY-2449 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 57adfdd. Configure here.
| fi | ||
|
|
||
| #nginx -c "$(pwd)/nginx.conf" | ||
| uv run uvicorn main1:app --port 5001 --reload |
There was a problem hiding this comment.
uv not on PATH after install
Medium Severity
When uv is installed via curl | sh, the installer adds it to ~/.local/bin but doesn't update the PATH for the current shell. This causes the subsequent uv run command to fail with 'command not found' immediately after installation.
Reviewed by Cursor Bugbot for commit 57adfdd. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip/requirements.txtwithuv/pyproject.tomlfor dependency managementrun1.shandrun2.shto useuv runinstead of manual venv creation and pip installrequirements.txtRefs PY-2449
Test plan
pyproject.tomlincludes all dependencies from the originalrequirements.txtuv runrequirements.txtis removed🤖 Generated with Claude Code