Skip to content

build(test-error-sampler): Migrate to uv and pyproject.toml #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 1 commit into from
May 21, 2026
Merged

build(test-error-sampler): Migrate to uv and pyproject.toml #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test-error-sampler/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[project]
name = "test-error-sampler"
version = "0"
requires-python = ">=3.12"

@sentry sentry Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The requires-python constraint in pyproject.toml (>=3.12) conflicts with the version in .python-version (3.10.4), which will cause uv to fail.
Severity: HIGH

Suggested Fix

Align the Python versions. Either update the .python-version file to a version that satisfies >=3.12 (e.g., 3.12), or adjust the requires-python constraint in pyproject.toml to be compatible with 3.10.4 (e.g., >=3.10.4).

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: test-error-sampler/pyproject.toml#L4

Potential issue: The newly added `pyproject.toml` file specifies `requires-python =
">=3.12"`. However, the existing `.python-version` file in the same directory pins the
Python version to `3.10.4`. When `uv` is used to run the project, it prioritizes the
`.python-version` file for interpreter selection but then validates it against the
`requires-python` constraint. Since version `3.10.4` does not meet the `>=3.12`
requirement, `uv` will report an incompatibility error, causing the `run.sh` script to
fail.

Did we get this right? 👍 / 👎 to inform future reviews.


dependencies = [
"ipdb>=0.13.13",
"sentry-sdk",
]

[tool.uv.sources]
sentry-sdk = { path = "../../sentry-python", editable = true }
4 changes: 0 additions & 4 deletions test-error-sampler/requirements.txt
View file
Open in desktop

This file was deleted.

11 changes: 4 additions & 7 deletions test-error-sampler/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
#!/usr/bin/env bash

set -euo pipefail

reset

python -m venv .venv
source .venv/bin/activate

pip install -r requirements.txt

@cursor cursor Bot May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uv missing PATH after install

Medium Severity

When uv is not already installed, run.sh runs the Astral installer and then immediately invokes uv run. The installer only updates shell startup files for future sessions, so uv is often not on PATH in the current bash process and the script exits before main.py runs.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ed198d3. Configure here.

if ! command -v uv &> /dev/null; then
curl -LsSf https://astral.sh/uv/install.sh | sh
fi

python main.py
uv run python main.py
Loading