build(test-dramatiq): Migrate to uv and pyproject.toml#19
Merged
Conversation
Replace pip/requirements.txt with uv/pyproject.toml for dependency management. Update run.sh and run-worker.sh to use uv run instead of manual venv creation and pip install. Refs PY-2446 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment on lines
+5
to
+9
| if ! command -v uv &> /dev/null; then | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| fi | ||
|
|
||
| # Run script that sends task to dramatiq worker | ||
| python main.py | ||
| uv run python main.py |
There was a problem hiding this comment.
Bug: The script installs uv but fails to update the current shell's PATH, causing subsequent uv commands to fail on clean systems.
Severity: HIGH
Suggested Fix
After the uv installation command, either add ~/.local/bin to the PATH for the current session (e.g., export PATH="$HOME/.local/bin:$PATH") or call uv using its full path ($HOME/.local/bin/uv run ...). This ensures the executable is found in the same session it was installed in.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: test-dramatiq/run.sh#L5-L9
Potential issue: On a system where `uv` is not pre-installed, the script installs it to
`~/.local/bin/` but does not update the `PATH` of the current shell session. The
subsequent call to `uv run ...` fails with a 'command not found' error. Because the
script is configured with `set -euo pipefail`, this error causes the script to abort
immediately, making it impossible to run on a clean system. The same issue exists in the
`run-worker.sh` script.
Also affects:
test-dramatiq/run-worker.sh:5~14
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip/requirements.txtwithuv/pyproject.tomlfor dependency managementrun.shandrun-worker.shto useuv runinstead of manual venv creation and pip installrequirements.txtRefs PY-2446
Test plan
pyproject.tomlincludes all dependencies from the originalrequirements.txtuv runrequirements.txtis removed🤖 Generated with Claude Code