feat(outcomes): Added support for client reported outcomes#2081
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2081 +/- ##
==========================================
+ Coverage 91.14% 91.21% +0.06%
==========================================
Files 510 510
Lines 22191 22198 +7
==========================================
+ Hits 20227 20247 +20
+ Misses 1964 1951 -13
Continue to review full report at Codecov.
|
mitsuhiko
commented
Sep 5, 2021
Contributor
|
Some context on the volume we expect.
|
Contributor
Author
|
@fpacifici i will do some estimates on this. I think we should try to merge this PR so that in case new outcomes come our way we gain the validation of the values. |
fpacifici
approved these changes
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new outcome type
5which is reserved for recording events discarded on the client side.Refs getsentry/relay#1074