deps(ui): Upgrade react testing library dependencies#72137
Merged
Conversation
upgrades `@testing-library/react` from 14 -> 16. upgrades `@testing-library/dom` from 9 -> 10 Notes: - @testing-library/dom is now a peer dependency, have to install - Support for react 19 - Upgrades aria-query to 5.3.0 testing-library/dom-testing-library#1241 - changes getByRole('link') `a element now requires a set href attribute to have an implicit link role`
evanpurkhiser
approved these changes
Jun 5, 2024
scttcper
commented
Jun 5, 2024
| expect(screen.getByRole('list')).toBeInTheDocument(); | ||
|
|
||
| const org1Link = screen.getByRole('link', {name: 'org1 Organization 1'}); | ||
| const org1Link = screen.getByRole('link', {name: 'O Organization 1'}); |
Member
Author
There was a problem hiding this comment.
i think it was able to get the aria label on the svg before.
now it is the literal text of the avatar
the link content looks like this
<avatar aria-label="org1">O</avatar> Organization 1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72137 +/- ##
===========================================
+ Coverage 63.54% 77.92% +14.38%
===========================================
Files 6571 6571
Lines 292731 292749 +18
Branches 50530 50533 +3
===========================================
+ Hits 186002 228131 +42129
+ Misses 98399 58367 -40032
+ Partials 8330 6251 -2079 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrades
@testing-library/reactfrom 14 -> 16.upgrades
@testing-library/domfrom 9 -> 10Notes:
a element now requires a set href attribute to have an implicit link role