theme: theme.background to theme.tokens.background.primary #104658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar notion as the theme.textColor change, we are migrating away from top level theme properties to the use of semantic tokens.
Going forward, the best way to use this is through the
<Container background="primary"/>component or its Flex, Stack or Grid supersets. For dynamic background usages, please continue to use styled with access totheme.tokens.background.primary. In the future, we will provide the primitives for this as well, but we are deferring implemnetation until we see more patterns emerge (if you have thoughts on the API design, please let the design engineering know)Ref DE-331