fix(ACI): Correctly read target_type and target_identifier values from Action.config #104634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104634 +/- ##
========================================
Coverage 80.47% 80.47%
========================================
Files 9349 9349
Lines 401504 401505 +1
Branches 25802 25802
========================================
+ Hits 323129 323130 +1
Misses 77933 77933
Partials 442 442 |
dda78b2 to
6737b7c
Compare
ceorourke
commented
Dec 10, 2025
| from sentry.models.organizationmemberteam import OrganizationMemberTeam | ||
| from sentry.models.projectownership import ProjectOwnership | ||
| from sentry.models.rule import Rule | ||
| from sentry.notifications.types import ActionTargetType, FallthroughChoiceType |
Member
Author
There was a problem hiding this comment.
This diff is rough - here's what I changed:
- Prefixed old tests with
legacy - Used enums instead of hard coding strings
- Refactored a bit to move reused vars into a
setUpmethod - Replicated all the legacy tests with workflow engine equivalents
ceorourke
commented
Dec 10, 2025
29f93c5 to
17fdc4c
Compare
cathteng
reviewed
Dec 10, 2025
| } | ||
| target_type = ActionTargetType(self.data["targetType"]) | ||
| target_identifier = self.data.get("targetIdentifier", None) | ||
| # XXX: temporarily support both types, after ACI GA we should only need to support snake case |
Member
There was a problem hiding this comment.
Unfortunately we'll need to support both until we completely rewrite how we send notifications 🥲 so we don't use Rules anymore
cathteng
approved these changes
Dec 10, 2025
17fdc4c to
12d1b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #104613 to properly read
target_typeandtarget_identifierfromActionmodels'configfield - we store them in snake case, not camel case. For now we need to support both as we are still processing some rules through the old system.