-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(seer): Seer org-level bulk project settings page #104594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
static/gsApp/views/seerAutomation/components/projectTable/seerProjectTable.tsx
Outdated
Show resolved
Hide resolved
static/app/components/events/autofix/preferences/hooks/useUpdateProjectAutomation.tsx
Show resolved
Hide resolved
static/gsApp/views/seerAutomation/components/projectTable/seerProjectTableRow.tsx
Outdated
Show resolved
Hide resolved
static/gsApp/views/seerAutomation/components/projectTable/seerProjectTableRow.tsx
Show resolved
Hide resolved
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
static/gsApp/views/seerAutomation/components/projectTable/seerProjectTableRow.tsx
Show resolved
Hide resolved
| onChange={() => { | ||
| // This preference can only be turned off, not on, from here. | ||
| // You need to go to the project settings page to turn it on. | ||
| updateProjectSeerPreferences( | ||
| { | ||
| repositories: preference?.repositories || [], | ||
| automated_run_stopping_point: 'background_agent', | ||
| automation_handoff: preference?.automation_handoff, | ||
| }, | ||
| { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional
| // const automatedRunStoppingPoint = value ? 'open_pr' : 'code_changes'; | ||
| // Set preferences.automated_run_stopping_point for all _selectedIds | ||
| // See: useUpdateProjectSeerPreferences() | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Bulk action handlers are empty stub functions
The handleBulkAutoFix and handleBulkPRCreate functions are empty stubs with only comments indicating what they should do. The dropdown menus for bulk "Auto Fix" and "PR Creation" actions are visible and clickable when projects are selected, but clicking them does nothing. Users will expect these bulk actions to work, but they silently fail with no feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup. will revisit this when i have info about the bulk endpoints.
billyvg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something weird happens when I load/switch the tab, it redirects me to prod. not sure if it's just env related.
| project: Project; | ||
| } | ||
|
|
||
| export default function SeerProjectTableRow({project, organization}: Props) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow-up we should split this component up so that we can memoize the row, should improve perf a bit with large tables.
static/gsApp/views/seerAutomation/components/projectTable/seerProjectTableRow.tsx
Outdated
Show resolved
Hide resolved
I'm not seeing this in dev locally. That could be something env related in https://github.com/getsentry/sentry/blob/master/static/gsApp/views/seerAutomation/components/settingsPageTabs.tsx |
New settings page, summary of project settings inside the Org>Seer settings area.
One big deviation from the designs is that I've added a column for Cursor Agent (it could also be labelled something like 'Delegated Agent' because it should be the same for any delegated agent).
We need this because if we're delegating a project to an agent we should:
a) show that it's delegated
b) disable the "PR Creation" toggle. That toggle only applies to Seer, not delegated agents (they'll have their own config elsewhere)
So now we have the column, and a bunch of logic for enabling/disabling the checkboxes
Note that you can only enable delegation by going to the Project Settings page directly, because there's a few options to pick it won't all fit in here.