Skip to content

Conversation

@AbhiPrasad
Copy link
Member

AI Summary going from 10.23.0 -> 10.27.0.

Critical Breaking/Deprecation Changes

1. Metrics Now Enabled by Default (10.24.0)

  • Metrics are now enabled by default (previously experimental)
  • enableMetrics and beforeSendMetric moved out of _experiments to top-level config
  • You can disable with enableMetrics: false if needed
  • Old _experiments metric options are deprecated

2. Browser Profiling Changes (10.27.0)

  • Transaction-based profiling with profilesSampleRate is now deprecated
  • New UI Profiling with profileSessionSampleRate is the recommended approach
  • New manual lifecycle mode (default) allows manual control:
    Sentry.uiProfiler.startProfiler()
    Sentry.uiProfiler.stopProfiler()

Important Fixes

3. Web Vitals Updated (10.26.0)

  • web-vitals bumped to 5.1.0
  • May include updated metrics and thresholds for Core Web Vitals

4. Spotlight in Development Bundles (10.25.0)

  • Spotlight debugging tool now included in development bundles
  • Helpful for local debugging during development

@AbhiPrasad AbhiPrasad self-assigned this Nov 27, 2025
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner November 27, 2025 19:53
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 27, 2025
Comment on lines +122 to +123
profileSessionSampleRate: shouldOverrideBrowserProfiling ? 1 : 0.1,
profileLifecycle: 'trace',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: profileLifecycle: 'trace' is incorrectly set in browser Sentry SDK initialization, as it's a Node.js-specific profiling option.
Severity: MEDIUM | Confidence: High

🔍 Detailed Analysis

The Sentry SDK is initialized with profileLifecycle: 'trace' in initializeSdk.tsx, which is a browser context. This option is specific to Node.js environments and is not applicable to browser profiling. The browser SDK will likely ignore this option, leading to profiling not functioning as intended, or potentially causing unexpected behavior due to misconfiguration. Browser profiling should be configured using profileSessionSampleRate.

💡 Suggested Fix

Remove the profileLifecycle: 'trace' option from the Sentry SDK initialization in initializeSdk.tsx as it is not relevant for browser environments. Ensure browser profiling is configured solely using profileSessionSampleRate.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/bootstrap/initializeSdk.tsx#L122-L123

Potential issue: The Sentry SDK is initialized with `profileLifecycle: 'trace'` in
`initializeSdk.tsx`, which is a browser context. This option is specific to Node.js
environments and is not applicable to browser profiling. The browser SDK will likely
ignore this option, leading to profiling not functioning as intended, or potentially
causing unexpected behavior due to misconfiguration. Browser profiling should be
configured using `profileSessionSampleRate`.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 4127918

@AbhiPrasad AbhiPrasad merged commit 7798c03 into master Nov 28, 2025
49 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-upgrade-sdk branch November 28, 2025 17:40
jerryzhou196 pushed a commit that referenced this pull request Dec 1, 2025
AI Summary going from `10.23.0` -> `10.27.0`.

## Critical Breaking/Deprecation Changes

### 1. **Metrics Now Enabled by Default** (10.24.0)
- Metrics are now **enabled by default** (previously experimental)
- `enableMetrics` and `beforeSendMetric` moved out of `_experiments` to
top-level config
- You can disable with `enableMetrics: false` if needed
- Old `_experiments` metric options are deprecated

### 2. **Browser Profiling Changes** (10.27.0)
- **Transaction-based profiling with `profilesSampleRate` is now
deprecated**
- New **UI Profiling** with `profileSessionSampleRate` is the
recommended approach
- New `manual` lifecycle mode (default) allows manual control:
  ```javascript
  Sentry.uiProfiler.startProfiler()
  Sentry.uiProfiler.stopProfiler()
  ```

## Important Fixes

### 3. **Web Vitals Updated** (10.26.0)
- `web-vitals` bumped to 5.1.0
- May include updated metrics and thresholds for Core Web Vitals

### 4. **Spotlight in Development Bundles** (10.25.0)
- Spotlight debugging tool now included in development bundles
- Helpful for local debugging during development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants