ref(redis): Do not use redis-blaster for snowflake IDs generation #103967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
approved these changes
Nov 25, 2025
Contributor
|
PR reverted: bda4505 |
getsentry-bot
added a commit
that referenced
this pull request
Nov 26, 2025
…tion (#103967)" This reverts commit 278ba81. Co-authored-by: markstory <[email protected]>
Member
|
reverted as this may be contributing to CI flakiness. |
markstory
added a commit
that referenced
this pull request
Nov 26, 2025
Using two different keys for organization snowflakeids results in duplicate sequence values when both are used. We end up using both as organizations created by `Factories.create_organization()` use the key from `Organization` while organizations created via the API endpoint use the module level key. Having the same key allows monolith mode deployments (and tests) that use a shared redis to not generate overlapping sequence values. Refs #103967
markstory
added a commit
that referenced
this pull request
Nov 27, 2025
…4075) Using two different keys for organization snowflakeids results in duplicate sequence values when both are used. We end up using both as organizations created by `Factories.create_organization()` use the key from `Organization` while organizations created via the API endpoint use the module level key. Having the same key allows monolith mode deployments (and tests) that use a shared redis to not generate overlapping sequence values. Refs #103967
markstory
added a commit
that referenced
this pull request
Dec 1, 2025
jerryzhou196
pushed a commit
that referenced
this pull request
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate snowflake generation away from redis-blaster based client.
To make sure that we have a separate sequence for each model we now include its redis key in the timestamp key. #102638 (comment)