fix(ACI): Accept fallthrough type in actions #103694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sentry/notifications/notification_action/action_handler_registry/email_handler.py
Show resolved
Hide resolved
saponifi3d
approved these changes
Nov 19, 2025
| "sentry.notifications.notification_action.registry.action_validator_registry.get", | ||
| return_value=MockActionValidatorTranslator, | ||
| ) | ||
| def test_create_workflow__with_fallthrough_type_action( |
tests/sentry/workflow_engine/endpoints/test_organization_workflow_index.py
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103694 +/- ##
===========================================
+ Coverage 80.51% 80.61% +0.10%
===========================================
Files 9274 9278 +4
Lines 395967 396089 +122
Branches 25250 25250
===========================================
+ Hits 318819 319325 +506
+ Misses 76688 76304 -384
Partials 460 460 |
Member
|
Do we need a backfill migration to fix this for existing actions? All existing actions will have the old camelCase key |
10f0042 to
f14233e
Compare
| action_data = action.data.copy() | ||
| if action.data.get("fallthroughType"): | ||
| del action_data["fallthroughType"] | ||
| action_data["fallthrough_type"] = action.data["fallthroughType"] |
Contributor
There was a problem hiding this comment.
Bug: CamelCase key silently overwrites snake_case key
When both fallthroughType and fallthrough_type keys exist in action.data, the camelCase version silently overwrites the snake_case version. The schema allows both keys simultaneously without mutual exclusivity constraints, and the conversion logic on line 58 unconditionally overwrites fallthrough_type with the value from fallthroughType, potentially discarding the user's intended value.
mifu67
approved these changes
Nov 24, 2025
Contributor
mifu67
left a comment
There was a problem hiding this comment.
LGTM, but you might want to wait for frontend review too
ceorourke
added a commit
that referenced
this pull request
Nov 25, 2025
Companion PR to #103694 to migrate `fallthroughType` to `fallthrough_type` in `Action.data`. Other PR must be merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "suggested assignees" are selected when creating an action that uses the fallthrough type the schema was incorrectly expecting it to be camel case instead of snake case which prevented the action from being created. This updates that and adds a test case around that particular action.
For now we must support both types until we can run a migration, after which I can go back and remove support for the incorrect camel case type.
Fixes https://getsentry.atlassian.net/browse/ACI-504
Related migration #103764