chore(aci): Actually delete WorkflowFireHistory.is_single_written

[kcons]

Finalize the field removal.

[cursor]

Bug: Field deletion should be post-deployment migration

The migration uses DeletionAction.DELETE to physically drop the is_single_written column from the database, but is_post_deployment is set to False. This means the column will be dropped during deployment while old code might still be running, potentially causing errors. Since the field was already moved to pending deletion in migration 0100 and removed from the model code, this migration should have is_post_deployment = True to ensure the column is only dropped after all servers are running the new code that no longer references it.

 

[kcons]

Pretty sure you're wrong. The whole point of the pending dance is to make it safe. The guidelines for post-deploy don't call out this very normal sort of migration, and other examples of similar migrations aren't post migration.
I think you're being a little silly.

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0101_remove_is_single_written_field.py

for 0101_remove_is_single_written_field in workflow_engine

--
-- Remove field is_single_written from workflowfirehistory
--
ALTER TABLE "workflow_engine_workflowfirehistory" DROP COLUMN "is_single_written" CASCADE;