Skip to content

fix: Organisation no longer required for Sentry CLI options#2137

Merged
bruno-garcia merged 5 commits intomainfrom
fix/cli-options-org
May 3, 2025
Merged

fix: Organisation no longer required for Sentry CLI options#2137
bruno-garcia merged 5 commits intomainfrom
fix/cli-options-org

Conversation

@bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Apr 30, 2025

Fixes #2058

This PR made the SDK respect Organisation tokens. Users using the the wizard going forward, won't have the Organisation set on the options as the org-slug will be taken from the embeddings of the token.

In case on non-organisation tokens (i.e. user tokens), the organisation can still be provided and will be used.
Screenshot 2025-05-02 at 13 05 34
Screenshot 2025-05-02 at 13 05 56

The relevant changes to tokens and sentry-cli are

@bruno-garcia
Copy link
Member

Rerunning 2019 smoke test:

Run $runtime = "16.1"
  $runtime = "16.1"
  If ($runtime -ne "latest")
  {
    $runtime = "iOS " + $runtime
  }
  ./Scripts/smoke-test-ios.ps1 Test "$runtime" -IsIntegrationTest
  shell: /usr/local/bin/pwsh -command ". '{0}'"
  env:
    MD_APPLE_SDK_ROOT: /Applications/Xcode_14.1.app
Args received Action=Test, SelectedRuntime=iOS 16.1, IsIntegrationTest=True
Retrieving list of available simulators
Available simulators:
Picking simulator based on selected runtime
Found 10 devices on version iOS 16.1
Starting Simulator iPhone SE (3rd generation) UUID 5863B493-8A4F-4[2](https://github.com/getsentry/sentry-unity/actions/runs/14794018179/job/41537711275?pr=2137#step:6:2)A5-8D1B-C98722157[3](https://github.com/getsentry/sentry-unity/actions/runs/14794018179/job/41537711275?pr=2137#step:6:3)C1
Installing Smoke Test on iPhone SE (3rd generation): OK
Test: 'smoke'
Launching 'smoke' test on 'iPhone SE (3rd generation)'
'smoke' test STATUS: PASSED
iPhone SE (3rd generation) Console Output
Test: 'hasnt-crashed'
Launching 'hasnt-crashed' test on 'iPhone SE (3rd generation)'
'hasnt-crashed' test STATUS: PASSED
iPhone SE (3rd generation) Console Output
Running crash test with server
Starting the crash-test-server on http://localhost:[8](https://github.com/getsentry/sentry-unity/actions/runs/14794018179/job/41537711275?pr=2137#step:6:8)000
Test: 'crash'
Launching 'crash' test on 'iPhone SE (3rd generation)'
Error: The action 'Run iOS Smoke Tests' has timed out after 20 minutes.

@bruno-garcia bruno-garcia merged commit 29a0f5d into main May 3, 2025
75 checks passed
@bruno-garcia bruno-garcia deleted the fix/cli-options-org branch May 3, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Org Slug configured in Unity SDK is ignored by sentry-cli

2 participants