Skip to content

feat(sdk): Add ClientReports#2496

Merged
krystofwoldrich merged 12 commits into
mainfrom
krystofwoldrich/addClientReports
Sep 27, 2022
Merged

feat(sdk): Add ClientReports#2496
krystofwoldrich merged 12 commits into
mainfrom
krystofwoldrich/addClientReports

Conversation

@krystofwoldrich

@krystofwoldrich krystofwoldrich commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

If clientReport exists it will be send with the next envelope.

💡 Motivation and Context

Closes: #2034

💚 How did you test it?

Unit tests, sample app, checked the client dropped in the graph

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions

github-actions Bot commented Sep 26, 2022

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4529d27

Kryštof Woldřich added 2 commits September 26, 2022 13:20
Comment thread src/js/sdk.tsx
Comment thread src/js/client.ts
@krystofwoldrich krystofwoldrich marked this pull request as ready for review September 27, 2022 09:11
Comment thread src/js/client.ts Outdated

@marandaneto marandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krystofwoldrich
LGTM.

Comment thread CHANGELOG.md
Comment thread src/js/sdk.tsx
@krystofwoldrich krystofwoldrich merged commit 7122f76 into main Sep 27, 2022
@krystofwoldrich krystofwoldrich deleted the krystofwoldrich/addClientReports branch September 27, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 'Client Reports' to the React Native SDK

2 participants