Skip to content

feat(crashpad): wait-for-upload macOS support #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpnurmi merged 4 commits into from
Apr 28, 2026
Merged

feat(crashpad): wait-for-upload macOS support #1679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e56cd2f
feat(crashpad): wait-for-upload macOS support
jpnurmi Apr 28, 2026
ffa3d54
Update CHANGELOG.md
jpnurmi Apr 28, 2026
bca3842
Bump crashpad
jpnurmi Apr 28, 2026
1107078
Merge remote-tracking branch 'upstream/master' into jpnurmi/feat/cras…
jpnurmi Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
**Features**:

- Enable structured logs by default; logs are now opt-out via `sentry_options_set_enable_logs(options, false)`. ([#1673](https://github.com/getsentry/sentry-native/pull/1673))
- Crashpad: add macOS support for the `crashpad_wait_for_upload` flag. ([#1679](https://github.com/getsentry/sentry-native/pull/1679), [crashpad#152](https://github.com/getsentry/crashpad/pull/152))

**Fixes**:

Expand Down
2 changes: 1 addition & 1 deletion external/crashpad
Open in desktop
Submodule crashpad updated 4 files
+15 −4 client/crashpad_client_mac.cc
+5 −5 handler/handler_main.cc
+7 −1 handler/mac/crash_report_exception_handler.cc
+4 −0 handler/mac/crash_report_exception_handler.h
4 changes: 2 additions & 2 deletions include/sentry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1840,8 +1840,8 @@ sentry_options_get_crash_reporting_mode(const sentry_options_t *opts);
* Enables a wait for the crash report upload to be finished before shutting
* down. This is disabled by default.
*
* This setting only has an effect when using the `crashpad` backend on Linux
* and Windows.
* This setting only has an effect when using the `crashpad` backend on Linux,
* Windows and macOS.
*/
SENTRY_API void sentry_options_set_crashpad_wait_for_upload(
sentry_options_t *opts, int wait_for_upload);
Expand Down
Loading