fix(nextjs/instrumentation): warn about missing onRequestError handler#15488
Merged
fix(nextjs/instrumentation): warn about missing onRequestError handler#15488
Conversation
lforst
reviewed
Feb 25, 2025
|
|
||
| if (runtime !== 'client') { | ||
| warnAboutDeprecatedConfigFiles(projectDir, runtime); | ||
| warnAboutMissingonRequestErrorHandler(projectDir); |
Contributor
There was a problem hiding this comment.
Let's do this only for runtime === 'nodejs'.
Collaborator
Author
There was a problem hiding this comment.
the runtime is either: client | edge | server
I used server for now
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
and only warn about missing onRequestError when an instrumentation file exists
lforst
reviewed
Feb 25, 2025
lforst
approved these changes
Feb 25, 2025
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
Member
|
@a-hariti please use squash-merge next time 🙏 |
3 tasks
kachkaev
reviewed
Mar 14, 2025
Comment on lines
+447
to
+452
| const instrumentationPaths = [ | ||
| ['src', 'instrumentation.ts'], | ||
| ['src', 'instrumentation.js'], | ||
| ['instrumentation.ts'], | ||
| ['instrumentation.js'], | ||
| ]; |
There was a problem hiding this comment.
Looks like this approach does not respect pageExtensions in Next.js config. I created #15652 to track this bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15049
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).