-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
Description
Note
The pull request "fix(e2e): Pin @opentelemetry/api to 1.9.0 in ts3.8 test app" was created by @logaretm but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.
Summary
@opentelemetry/api@1.9.1was released on Mar 25 and introducedexport { Foo, type Bar }syntax (inline type modifiers) in its.d.tsfiles, which requires TypeScript 4.5+- The
generic-ts3.8E2E test runs withskipLibCheck: falseand TypeScript 3.8, so it tries to parse OTel's types and fails - This pins
@opentelemetry/apito1.9.0in the ts3.8 test app viapnpm.overrides - We can't pin repo-wide in published packages because OTel uses a global singleton pattern — version mismatches with
@opentelemetry/sdk-trace-basecause the tracer to become a no-op - Our published
.d.tsfiles are unaffected — only OTel's own types use the incompatible syntax
Test plan
- Verified locally:
yarn test:run generic-ts3.8passes with the pin - CI
E2E generic-ts3.8 Testshould go green
🤖 Generated with Claude Code
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Fields
Give feedbackNo fields configured for issues without a type.