Skip to content

Polish samples #1281

Description

@marandaneto

A few things could be improved in our samples, eg:

mainClassName Gradle property is deprecated, could use mainClass.set(...)

every sample should set options.addInAppInclude("io.sentry.samples"); if not set automatically (Android does), so we get proper inApp frames.
this could be done either via options as described above or sentry.properties file.

samples-jul is not reporting events at all.

call Sentry.flush if sample has a short lifecycle, which might be the case for Console, JUL etc samples, maybe the ShutdownHookIntegration does it automatically, but I'm not sure that this hook is invoked for every type of App, it does not for Android for instance.

cc @maciejwalkowiak

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions