Spans created by SentrySpanClientHttpRequestInterceptor only show request method

[dparrella]

Platform:

• Android -> If yes, which Device API (and compileSdkVersion/targetSdkVersion/Build tools) version?
• Java -> If yes, which Java (and sourceCompatibility/targetCompatibility) version? JDK 11
• Kotlin -> If yes, which Kotlin (and jvmTarget) version?
• NDK -> If yes, which NDK/CMake version?
• React-Native -> If yes, which version?
• Timber -> If yes, which version?
• Log4j2 -> If yes, which version?
• Logback -> If yes, which version?
• Spring -> If yes, which version? 5.3.3

IDE:

• Android Studio -> If yes, which version?
• IntelliJ -> If yes, which version?
• Other -> If yes, which one?

Build system:

• Gradle -> If yes, which version?
• Buck -> If yes, which version?
• Bazel -> If yes, which version?
• Maven -> If yes, which version?
• Other -> If yes, which one?

Android Gradle Plugin:

• Yes -> If yes, which version?
• No

Sentry Android Gradle Plugin:

• Yes -> If yes, which version?
• No

Proguard/R8:

• Enabled
• Disabled

Platform installed with:

• JCenter
• Bintray
• Maven Central
• Manually

The version of the SDK:
4.0.0

---

I have the following issue:

Spans created by the SentrySpringClientHttpRequestInterceptor only show the request method (e.g. GET). The request URL is null.

Example trace:

Steps to reproduce:

• Step

Actual result:

• Actual

Expected result:

• Spans should show the request method AND request URL. Otherwise we don't know what request was being made.

[maciejwalkowiak]

Could you please show how you create the RestTemplate bean? The correct way to do it is:

  @Bean
  RestTemplate restTemplate(IHub hub) {
    RestTemplate restTemplate = new RestTemplate();
    SentrySpanClientHttpRequestInterceptor sentryRestTemplateInterceptor =
        new SentrySpanClientHttpRequestInterceptor(hub);
    UriTemplateHandler templateHandler = restTemplate.getUriTemplateHandler();
    restTemplate.setUriTemplateHandler(
        sentryRestTemplateInterceptor.createUriTemplateHandler(templateHandler));
    restTemplate.setInterceptors(Collections.singletonList(sentryRestTemplateInterceptor));
    return restTemplate;
  }

I was able to reproduce your issue only if I don't set the UriTemplateHandler on the RestTemplate.

[dparrella]

That seems pretty backwards to me considering this is an interceptor. We have a way to customize interceptors for most of our RestTemplates. If we have to go and do this for every RestTemplate we create that's a non-starter.

…

On Wed, Feb 10, 2021 at 8:19 PM Maciej Walkowiak ***@***.***> wrote: Could you please show how you create the RestTemplate bean? The correct way to do it is: @bean RestTemplate restTemplate(IHub hub) { RestTemplate restTemplate = new RestTemplate(); SentrySpanClientHttpRequestInterceptor sentryRestTemplateInterceptor = new SentrySpanClientHttpRequestInterceptor(hub); UriTemplateHandler templateHandler = restTemplate.getUriTemplateHandler(); restTemplate.setUriTemplateHandler( sentryRestTemplateInterceptor.createUriTemplateHandler(templateHandler)); restTemplate.setInterceptors(Collections.singletonList(sentryRestTemplateInterceptor)); return restTemplate; } I was able to reproduce your issue only if I don't set the UriTemplateHandler on the RestTemplate. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1240 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHF5XI7UR3PHCLKJEGVZCTS6JTUXANCNFSM4XMKZDLA> .

[maciejwalkowiak]

@dparrella understood, thanks for reporting, we will simplify the RestTemplate instrumentation.

[marandaneto]

@maciejwalkowiak let's fix the docs before closing this issue:

https://docs.sentry.io/platforms/java/guides/spring/performance/included-instrumentation/#resttemplate-instrumentation