fix: Log Warning instead of Error when ratelimited#4927
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Fixes 🐛
Dependencies ⬆️Deps
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4927 +/- ##
==========================================
+ Coverage 73.86% 73.88% +0.01%
==========================================
Files 496 496
Lines 17927 17947 +20
Branches 3511 3516 +5
==========================================
+ Hits 13242 13260 +18
- Misses 3824 3825 +1
- Partials 861 862 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this consistent with what the other SDKs do for 429 response codes? Arguably the user's tests could use mocks rather than a real Sentry instance... so I'm not sure if we want to change the SDK here to make one user's tests pass. |
This is a red herring. It's not about user tests, they are just surfacing an inconsistency. The other SDKs are also all over the place, checking a few: Python and Dart logs a My argument is still: If this is handled and expected behaviour, why is this an error. |
jamescrosswell
left a comment
There was a problem hiding this comment.
Looks fine.
btw: You shouldn't need to explicitly add a changelog anymore... these get generated automatically from the PR descriptions now (for future reference).
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Sentry.Maui](https://sentry.io/) ([source](https://github.com/getsentry/sentry-dotnet)) | nuget | minor | `6.1.0` -> `6.2.0` | --- ### Release Notes <details> <summary>getsentry/sentry-dotnet (Sentry.Maui)</summary> ### [`v6.2.0`](https://github.com/getsentry/sentry-dotnet/blob/HEAD/CHANGELOG.md#620) [Compare Source](getsentry/sentry-dotnet@6.1.0...6.2.0) ##### Features - Outbound HTTP requests now show in the Network tab for Android Session Replays ([#​4860](getsentry/sentry-dotnet#4860)) ##### Fixes - The SDK now logs a `Warning` instead of an `Error` when being ratelimited ([#​4927](getsentry/sentry-dotnet#4927)) - Symbolication now works correctly with Android workloads 10.0.102 and later ([#​4998](getsentry/sentry-dotnet#4998)) - `libmonosgen` and `libxamarin` frames no longer show as in-app ([#​4960](getsentry/sentry-dotnet#4960)) ##### Dependencies - Bump Native SDK from v0.12.6 to v0.13.2 ([#​4920](getsentry/sentry-dotnet#4920), [#​4929](getsentry/sentry-dotnet#4929), [#​4941](getsentry/sentry-dotnet#4941), [#​4964](getsentry/sentry-dotnet#4964), [#​4996](getsentry/sentry-dotnet#4996)) - Bump Cocoa SDK from v8.57.3 to v9.5.0 ([#​4781](getsentry/sentry-dotnet#4781), [#​4928](getsentry/sentry-dotnet#4928), [#​4944](getsentry/sentry-dotnet#4944)) - Bump CLI from v2.58.2 to v3.3.0 ([#​4805](getsentry/sentry-dotnet#4805), [#​4943](getsentry/sentry-dotnet#4943), [#​4973](getsentry/sentry-dotnet#4973)) - NOTE: Sentry CLI v3 removed support for the legacy API key authentication method. Sentry CLI now only supports authenticating with Auth Tokens. If you are using API key authentication via `SentryApiKey`, you need to generate an [Auth Token](https://docs.sentry.io/account/auth-tokens/) and use `SentryAuthToken`, instead. - Bump Java SDK from v8.32.0 to v8.34.1 ([#​4933](getsentry/sentry-dotnet#4933), [#​4986](getsentry/sentry-dotnet#4986)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/di...
Surfaced through getsentry/sentry-unity#2538
This PR addresses an inconsistency in expected, recoverable behaviour that has - as per log message - no effect on the user's application. Same as dropping events with too large attachments.