Test projects cleanup#1762
Merged
Merged
Conversation
mattjohnsonpint
commented
Jun 30, 2022
|
|
||
| <!-- Running these tests on Mono fail --> | ||
| <PropertyGroup Condition="'$(OS)' == 'Windows_NT'"> | ||
| <PropertyGroup Condition="$([MSBuild]::IsOSPlatform('windows'))"> |
Contributor
Author
There was a problem hiding this comment.
Here's another case where we were checking incorrectly. If OS wasn't defined, then the tests didn't run for this target at all on any OS.
mattjohnsonpint
commented
Jun 30, 2022
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>net6.0;net5.0;netcoreapp3.1;netcoreapp2.1</TargetFrameworks> | ||
| <TargetFrameworks>net6.0;net5.0;netcoreapp3.1;netcoreapp2.1;net461</TargetFrameworks> |
Contributor
Author
There was a problem hiding this comment.
We can just include net461 directly now. The comment about the tests hanging on Mono appears to be not the case anymore. But note that it wasn't being included on Windows before because of the way we were checking.
Condition="'$(OS)' == 'Windows_NT'" is unsupported. The correct way is Condition="$([MSBuild]::IsOSPlatform('windows'))".
SimonCropp
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog