Skip to content

Bump: sentry-android to v4.0.0#287

Merged
bruno-garcia merged 3 commits into
mainfrom
bump/sentry-android-4.0.0
Jan 29, 2021
Merged

Bump: sentry-android to v4.0.0#287
bruno-garcia merged 3 commits into
mainfrom
bump/sentry-android-4.0.0

Conversation

@marandaneto

@marandaneto marandaneto commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

📜 Description

Bump: sentry-android to v4.0.0

💡 Motivation and Context

Using latest versions and fix on sentry-native

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Remove !! calls once getsentry/sentry-java#1213 is merged/released

@marandaneto marandaneto requested a review from a team January 29, 2021 09:54
@codecov-io

codecov-io commented Jan 29, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.52%. Comparing base (335a808) to head (e6b0d08).
⚠️ Report is 1923 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files          52       52           
  Lines        1751     1751           
=======================================
  Hits         1515     1515           
  Misses        236      236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philipphofmann philipphofmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🤩, CI is a bit complaining, though. Maybe at least update the changelog?

@marandaneto

Copy link
Copy Markdown
Contributor Author

Awesome 🤩, CI is a bit complaining, though. Maybe at least update the changelog?

fighting against my github cli after migrating to gh SSO :(

@bruno-garcia bruno-garcia merged commit 1f0125e into main Jan 29, 2021
@bruno-garcia bruno-garcia deleted the bump/sentry-android-4.0.0 branch January 29, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants