chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4#273
Draft
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4#273
Conversation
- vite ^5.2.8 → ^6.4.1 across all 18 workspace packages - vitest ^1.4.0 → ^2.1.9 across all packages that declare it - vite-plugin-dts ^3.8.1 → ^4.5.4 across all packages that declare it - Replace deprecated rollup-plugin-terser with @rollup/plugin-terser in rrweb-worker - Add cssFileName: 'style' to shared vite config to preserve backward-compatible CSS output filename (Vite 6 breaking change) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Vitest 2 changed `.toThrow('')` to match the empty string literally
instead of matching any error. Use `.toThrow()` (no argument) to match
any thrown error.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Yarn v1 can hang in CI when downloading many platform-specific optional dependencies (esbuild/rollup binaries added by Vite 6). Adding a 5-minute network timeout prevents indefinite hangs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Vitest 2 defaults to worker threads, but Puppeteer browser instances don't clean up reliably in threads, causing CI to hang indefinitely. Switch to forks pool (child processes) which matches vitest 1 behavior, and add a teardown timeout as a safety net. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The yarn cache from actions/setup-node appears to cause hangs during yarn install when the lockfile changes significantly (e.g. Vite 6 upgrade adding many new platform-specific optional deps). Disable caching to unblock CI while we investigate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Jest in rrvideo leaves open handles (likely Playwright browser) that prevent the process from exiting. This blocks the turbo test pipeline indefinitely. Add --forceExit to match common practice for E2E test suites. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the core build/test tooling across all workspace packages:
Added
cssFileName: 'style'to the shared vite config to preserve thestyle.cssoutput filename (Vite 6 changed the default to package-name-based).Dependabot alerts resolved
Fully resolved (vulnerable version completely removed from lockfile):
vitestrollupvue-template-compilerPartially resolved (some vulnerable entries removed, but package still exists via other dependency chains):
vite@sveltejs/vite-plugin-svelte@3still pulls in vite@5 (needs Svelte 5 upgrade)esbuildesbuild-plugin-umd-wrapperstill uses esbuild@0.18serialize-javascript@size-limit) still pulls in v6nanoidvalidator@microsoft/api-extractor(via vite-plugin-dts) — needs further investigationThe partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up).
closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts