fix: model options with intrinsics#972
Conversation
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
|
Test failures caused by known failure: #970 |
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
|
Intrinsics now support tools. Added tests to ensure that tools are actually getting sent to the model when generating and that generation still works. Required changes to the underlying granite library. |
| tokenizer_input = { | ||
| "conversation": request["messages"], | ||
| "add_generation_prompt": True, | ||
| "tools": request["tools"], |
There was a problem hiding this comment.
FYI @frreiss . Please let us know if there was a reason for granite-io dropped tools. (Fred: we're going ahead with merging this PR but even after this is merged and closed any "there be dragons ahead" warnings would be appreciated so we can get out ahead of them :))
There was a problem hiding this comment.
None of the training data for any of the intrinsics in granitelib-rag includes tool calls. Not sure about other models. In general, if tool calls are not in the model’s training data and the model is fed an input that contains a tool call, then the model is operating outside of the domain it was trained for. A model operating out of domain will produce lower quality results than one operating in domain. The drop in quality is unpredictable, ranging from “we got lucky and it just works” to “it fails completely”. Predicting the level of quality loss a priori is an open research problem.
* fix: model options with intrinsics Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS * fix: pre-commit issues Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> * fix: pr comments; add tools to intrinsics Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> * fix: test for intrinsics with tools Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS --------- Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
Misc PR
Type of PR
Description
io.yamlfile #954Verified that io.yaml parameters are used. Verified that model options override these. Added support for all model options with specific caveats for one of cases.
Testing
Attribution