fix: Document.parts() returns [] instead of raising NotImplementedError#637
Merged
jakelorocco merged 1 commit intoMar 13, 2026
Merged
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
approved these changes
Mar 13, 2026
Contributor
jakelorocco
left a comment
There was a problem hiding this comment.
lgtm; I think you built off the branch for #619. Not sure if you will have to do anything to resolve that. Please ensure the other one is approved and merged before this one.
6c75b19 to
402b448
Compare
402b448 to
0a8c736
Compare
Contributor
Author
ah. yes - found it when working on the docs & didn't rebase on main Fixed |
Merged
via the queue into
generative-computing:main
with commit Mar 13, 2026
3888476
4 checks passed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Description
Document.parts()raisesNotImplementedErrorinstead of returning an empty list, causing crashes when aDocumentis passed inside aMessagetoact()/aact()viagenerate_walk().Returns
[]to match the pattern used byRichDocumentandTable.Closes #636
Testing