Skip to content

fix: add missing requires_gpu and requires_heavy_ram markers to Huggi… #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
planetf1 wants to merge 1 commit into from
Closed

fix: add missing requires_gpu and requires_heavy_ram markers to Huggi… #621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/telemetry/test_metrics_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,12 @@ async def test_litellm_token_metrics_integration(
@pytest.mark.asyncio
@pytest.mark.llm
@pytest.mark.huggingface
@pytest.mark.requires_gpu
@pytest.mark.requires_heavy_ram
Comment on lines +300 to +301
Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered adding these, but in all my testing they didn't seem to apply. I saw these regularly take 30sec per run as long as the required model was already downloaded. I also made sure to choose a model that was used in other tests so these tests wouldn't download a new model only to use here

@pytest.mark.skipif(
int(os.environ.get("CICD", 0)) == 1,
reason="Skipping HuggingFace metrics test in CI - requires GPU and model download",
)
Comment on lines +302 to +305
Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is handled below by

if gh_run:
        pytest.skip("Skipping in CI - requires model download")

Should we replace that code with this decorator? Is the decorator the new standard way to skip in CI?

@pytest.mark.parametrize("stream", [False, True], ids=["non-streaming", "streaming"])
async def test_huggingface_token_metrics_integration(
enable_metrics, metric_reader, stream, gh_run
Expand Down
Loading