test: misc test cleanup — improve assertions, add diagnostics, fix markers#600
Merged
planetf1 merged 1 commit intoMar 6, 2026
Merged
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
071230e to
5f57294
Compare
…rkers - Strengthen test_generate_from_raw: check all results, add CONTEXT_WINDOW: 2048, timeout(150), and diagnostic assertion message - Increase MAX_NEW_TOKENS to 2**10 in format tests (prevents JSON truncation) - Add FancyLogger.warning when generate_from_raw catches an exception - Mark researcher.py example as slow; add markers to query_clarification.py - Update slow marker description to ">1 minute"
5f57294 to
0c45f44
Compare
jakelorocco
approved these changes
Mar 6, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: misc test cleanup — improve assertions, add diagnostics, fix markers
Type of PR
Description
Fixes #573
test_generate_from_raw: check all results (not just index 0), addCONTEXT_WINDOW: 2048,timeout(150), and diagnostic assertion messagetest_generate_from_raw_with_format: addCONTEXT_WINDOW: 2048, check all results, validate all 4 outputs (xfail retained — see Ollama returns empty-body responses under sustained load in generate_from_raw #599)MAX_NEW_TOKENSto2**10in Ollama and OpenAI-Ollama format tests (prevents truncation of constrained JSON output)FancyLogger.warningwhengenerate_from_rawcatches an exceptionresearcher.pyexample asslow; add markers toquery_clarification.pyslowmarker description to ">1 minute"Testing