Skip to content

fix: prevent example collection crash for readme_generator #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
planetf1 merged 2 commits into from
Mar 6, 2026
+13 −8
Merged

fix: prevent example collection crash for readme_generator #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e90a7
fix: prevent execution of readme_generator during pytest collection (…
planetf1 Mar 6, 2026
03134a3
fix: respect 'skip' marker during example collection
planetf1 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions docs/examples/aLora/example_readme_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@

from cli.alora.readme_generator import generate_readme, make_readme_jinja_dict

generate_readme(
dataset_path="stembolt_failure_dataset.jsonl",
base_model="granite-4.0-micro",
prompt_file=None,
output_path="stembolts_model_readme.md",
name="your-username/stembolts-alora",
hints=None,
)
if __name__ == "__main__":
generate_readme(
dataset_path="stembolt_failure_dataset.jsonl",
base_model="granite-4.0-micro",
prompt_file=None,
output_path="stembolts_model_readme.md",
name="your-username/stembolts-alora",
hints=None,
)
4 changes: 4 additions & 0 deletions docs/examples/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,10 @@ def _should_skip_collection(markers):
if "qualitative" in markers and gh_run == 1:
return True, "Skipping qualitative test in CI (CICD=1)"

# Explicitly skip if 'skip' marker is present
if "skip" in markers:
return True, "Example marked with skip marker"

# Skip slow tests if SKIP_SLOW=1 environment variable is set
if "slow" in markers and int(os.environ.get("SKIP_SLOW", 0)) == 1:
return True, "Skipping slow test (SKIP_SLOW=1)"
Expand Down
Loading