Support passing dicts and namedtuples for namedtuple arguments #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We support dicts (and other mappings), and for named tuples we do lookup by name instead of by position. Fixes #374.
elprans
reviewed
Jan 31, 2024
edgedb/protocol/codecs/base.pyx
Outdated
| item = obj[name] | ||
| elif is_namedtuple: | ||
| name = datatypes.record_desc_pointer_name(self.descriptor, i) | ||
| item = getattr(obj, name) |
Member
There was a problem hiding this comment.
Probably worth wrapping possible AttributeError/KeyError to make it nicer.
elprans
approved these changes
Feb 2, 2024
Member
Author
|
@raddevon We'll probably want some docs about this once we've got a version update out |
aljazerzen
pushed a commit
that referenced
this pull request
Feb 15, 2024
We support dicts (and other mappings), and for named tuples we do lookup by name instead of by position. Fixes #374.
aljazerzen
added a commit
that referenced
this pull request
Feb 24, 2024
Fixes ===== * Fix globals in nested modules (#474) (by @msullivan in ff08d9d for #474) * Support passing dicts and namedtuples for namedtuple arguments (#473) (by @msullivan in 60da99a for #374) * Expose the error details field. (#479) (by @vpetrovykh in 113ed0d for #472)
aljazerzen
added a commit
that referenced
this pull request
Feb 26, 2024
Fixes ===== * Fix globals in nested modules (#474) (by @msullivan in ff08d9d for #474) * Support passing dicts and namedtuples for namedtuple arguments (#473) (by @msullivan in 60da99a for #374) * Expose the error details field. (#479) (by @vpetrovykh in 113ed0d for #472)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support dicts (and other mappings), and for named tuples we do
lookup by name instead of by position.
Fixes #374.