Skip to content

Conversation

@mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Oct 26, 2023

See grpc/grpc-go#645

This change is Reviewable

@mdibaiee mdibaiee force-pushed the mahdi/update-grpc branch 5 times, most recently from 4d3782e to d34c1d3 Compare October 26, 2023 21:20
@mdibaiee mdibaiee marked this pull request as ready for review October 26, 2023 21:47
@mdibaiee mdibaiee requested a review from jgraettinger October 26, 2023 21:47
@jgraettinger
Copy link
Contributor

jgraettinger commented Oct 26, 2023

I'm definitely in favor of updating, but this first needs to be fully reconciled with #335

I don't have a handle on the API changes for gRPC balancers or the implications of updating, and we would need to verify all that first.

mdibaiee added a commit to estuary/connectors that referenced this pull request Nov 2, 2023
mdibaiee added a commit to estuary/connectors that referenced this pull request Nov 2, 2023
mdibaiee added a commit to estuary/connectors that referenced this pull request Nov 3, 2023
mdibaiee added a commit to estuary/connectors that referenced this pull request Nov 8, 2023
mdibaiee added a commit to estuary/connectors that referenced this pull request Nov 10, 2023
mdibaiee added a commit to estuary/connectors that referenced this pull request Nov 14, 2023
@mdibaiee
Copy link
Member Author

mdibaiee commented Nov 15, 2023

Changelog from 1.40.0 to 1.59.0 with notable behaviour changes:

The changes introduced in 1.58.0 are addressed in this pull-request.

Copy link
Contributor

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

See grpc/grpc-go#6481, specifically
weightedtarget_test.go as an example of how tests need to be migrated
now that UpdateSubConnState is deprecated. I have followed the same
example in our dispatcher_test.go
@mdibaiee mdibaiee merged commit 0fa83a6 into master Nov 21, 2023
@mdibaiee mdibaiee deleted the mahdi/update-grpc branch November 21, 2023 11:50
mdibaiee added a commit to estuary/connectors that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants