-
Notifications
You must be signed in to change notification settings - Fork 3
Unify the model parameter validation code introduced in PR 2092 with the DataValidator classes #2107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GernotMaier
merged 13 commits into
illuminator_south
from
illuminator_south_use_schema_module
Apr 3, 2026
Merged
Unify the model parameter validation code introduced in PR 2092 with the DataValidator classes #2107
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b0c2c81
add get_parameter_type_from_schema to schema
GernotMaier 9c525aa
use data validator
GernotMaier 280269e
fix heterogenous list
GernotMaier 935aa33
simplify schema
GernotMaier f7dd406
unify dimensionless data treatment
GernotMaier 61a08f5
simplification
GernotMaier dab9074
simplification
GernotMaier 46c482b
unit tests
GernotMaier cb30c16
Merge branch 'main' into illuminator_south_use_schema_module
GernotMaier 03b9f09
copilot suggestions
GernotMaier b3804b4
Merge branch 'illuminator_south' into illuminator_south_use_schema_mo…
GernotMaier 4354d1c
OG comments / improvements
GernotMaier 03b776b
Changed the num_gains changing tests to make sure the value always ch…
orelgueta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.