Fix versions

[EliasVal]

Changes

• Fixed missing 1 in some versions (apologies)

Checklist

• Read the contribution guide and accept the
  code of conduct
• Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
  a PR in the documentation repo)
• Readme (updated or not needed)
• Tests (added, updated or not needed)

[github-actions]

[codecov-commenter]

Codecov Report

Merging #559 (50aefc4) into main (43e1280) will not change coverage.
The diff coverage is n/a.

❗ Current head 50aefc4 differs from pull request most recent head d3feafb. Consider uploading reports for the commit d3feafb to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##             main     #559    +/-   ##
========================================
  Coverage   36.97%   36.97%            
========================================
  Files          77       77            
  Lines        3032     3032            
  Branches      623      623            
========================================
  Hits         1121     1121            
- Misses       1758     1908   +150     
+ Partials      153        3   -150     

see 38 files with indirect coverage changes

[EliasVal]

About the 2023.1.9f1 builds failing, the docker tags have a rolling version of 2 (ubuntu-2023.1.9f1-android-2) yet the ImageTag class hard-codes it so it attempts to fetch an image with a rolling version of 1 (ubuntu-2023.1.9f1-android-1, which does not exist)

a comment states that it Will automatically roll to the latest non-breaking version. yet it does not seem to do that, or my understanding is flawed.

[EliasVal]

@webbertakken If I understood #556 correctly, the rolling version of ALL images should now be 2, right? If so I am going to push a new commit now :)

[webbertakken]

About the 2023.1.9f1 builds failing, the docker tags have a rolling version of 2 (ubuntu-2023.1.9f1-android-2) yet the ImageTag class hard-codes it so it attempts to fetch an image with a rolling version of 1 (ubuntu-2023.1.9f1-android-1, which does not exist)

a comment states that it Will automatically roll to the latest non-breaking version. yet it does not seem to do that, or my understanding is flawed.

It does exactly that. Going from version 1 to 2 is a breaking change in https://semver.org/

That's what #556 is for. It changes that version. I was about to merge it but first rebased on your changes, at which point the workflows started failing.

You need to make sure that you assign versions that are actually available in v1. We purposefully didn't pick the very newest ones before, because we don't just support the newest ones.

After the workflows work again I'll merge said change.

[EliasVal]

ah I now saw your message, I'll change the versions to use images that have the -1 rolling version

[webbertakken]

I realise the versions page is a bit broken right now but you can use the dropdown to select v1.1.2.

[EliasVal]

@webbertakken The checks that previously failed have now succeeded, No idea why two of them are stuck though 🤔

[webbertakken]

Excellent. I've restarted the jobs that were stuck. It sometimes happens when workflows take a while, especially if you're running this many the chance is present.

[EliasVal]

@webbertakken Amazing! Thanks for the quick replies :)
Now there's only this PR left: game-ci/unity-test-runner#236 (before going to game-ci/docker)