push triggers pull, fix glitches#67
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 95.7% 95.49% -0.22%
==========================================
Files 13 13
Lines 1467 1465 -2
Branches 129 128 -1
==========================================
- Hits 1404 1399 -5
- Misses 63 66 +3
Continue to review full report at Codecov.
|
939b7d1 to
3a3cfd0
Compare
paldepind
requested changes
Sep 4, 2019
paldepind
approved these changes
Sep 4, 2019
Member
paldepind
left a comment
There was a problem hiding this comment.
Nice. Pretty sweet that glitched could be eliminated in this fairly elegant way 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should PR changes how push works with Behaviors.
Push now triggers a pull, which ensures that all the dependencies are calculated first, eliminating glitches in Behaviors.
I have added two simple tests showing exposing glitches.