Skip to content

PHP 8 fixes#10

Merged
krtek4 merged 23 commits intofunctional-php:masterfrom
ace411:master
Jul 11, 2021
Merged

PHP 8 fixes#10
krtek4 merged 23 commits intofunctional-php:masterfrom
ace411:master

Conversation

@ace411
Copy link
Collaborator

@ace411 ace411 commented May 26, 2021

The following changes have been made:

  • Fixed failing match syntax
  • Renamed match function to pmatch (PHP8 compatibility issues)
  • Applied PSR-12 code formatting
  • Replaced TravisCI with Github actions
  • Added StyleCI configuration

[True, 'true'], [True, 'True'], [True, 'TRUE'],
[TRUE, 'true'], [TRUE, 'True'], [TRUE, 'TRUE'],
[true, 'true'], [true, 'True'], [true, 'TRUE'],
[true, 'true'], [true, 'True'], [true, 'TRUE'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automatic formating kinda defeated the purpose of this test.

So either delete the duplicate lines or restore the casing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right. I'll remove the duplicate lines.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this out: 0860615

@krtek4 krtek4 merged commit ffd1266 into functional-php:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants