Update GetModels action and related configurations#117
Open
ayrtonandino wants to merge 5 commits intofumeapp:masterfrom
Open
Update GetModels action and related configurations#117ayrtonandino wants to merge 5 commits intofumeapp:masterfrom
ayrtonandino wants to merge 5 commits intofumeapp:masterfrom
Conversation
Member
|
oh interesting, thanks for the PR i will look over and review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request tries to solve a problem I’m having when working on Windows and Mac, for some reason the order of models being returned by
GetModels.phpchanges based on the OS.So when I’m at my windows pc I get interfaces alphabetically ordered, and on mac (I don’t know, by folder name?), this produces changes on git that are not real.
Solution, sort the resulting collection by class name.
But then I noticed that is really hard to understand what
GetModels.phpis actually doing, so I change the order of thing to be more Laravel like, and added missing types.Run pint to fix error present in codebase (from other pull requests) and change workflows to fail on pull requests not properly formatted.
Update
GetModelsTest.php.