fix nodejs environment usage in browser environments for v4.8.5#253
Merged
terehov merged 3 commits intofullstack-build:developmentfrom Aug 6, 2023
Merged
Conversation
Contributor
|
Question, why AND instead of OR? super(isBrowser && typeof(process) === 'undefined' ? BrowserRuntime : NodeRuntime, settings, logObj, isSafari ? 4 : 5);I think it should be like this: super(isBrowser || process == undefined ? BrowserRuntime : NodeRuntime, settings, logObj, isSafari ? 4 : 5); |
Contributor
|
Check out |
Contributor
Author
|
good question, i suppose both could be right. the AND, just assumes the window object exists, and the process object certainly doesn't, which in a sense could be more specific. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the NodeJS environment is imported by default, and tries to reference process and hostname(), this fails in a browser. Also it seems to default to always construct with the NodeJS Environment instances. note this pr is against the development branch.
NOTE, if using webpack this release requires disabling;