-
-
Notifications
You must be signed in to change notification settings - Fork 168
Closed
Labels
Description
This breaks API so we need to:
- Implement new API
- Reimplement old API utilizing new API
- Mark old API as deprecated
And then create a new issue:
- Remove deprecated API
- Bump major version
Changes
- Change
zoomSamples*to a range (this change is cosmetic)- Remove
zoomStartSamples - Remove
zoomEndSamples - Add
zoomSamples: CountableClosedRange<Int>
- Remove
- Change
highlightedSamplesto a range (related: Using 3+ colors #42, Multiple colors of Progress Samples #43 ) (this change now allows highlighting from somewhere that does not start at zero)- Remove
progressSamples - Add
highlightedRange: CountableClosedRange<Int>? - Rename
progressColortohighlightColor
- Remove
Implementation notes
Ranges have a few nifty methods that we can use:
func clamped(to: Range<Bound>)func contains(Bound)func overlaps(Range<Bound>)