[Repo Assist] Reduce dark mode border contrast#983
Merged
Conversation
The --header-border variable in dark mode was #9b9b9b (fairly light grey) against a near-black background rgb(20,21,26), creating high contrast dividers inconsistent with the subtle borders in light mode. Change to #3a3a42 to match the low-contrast feel of the light-mode borders. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
✅ Pull request created: #983 |
9 tasks
Collaborator
/repo-assist looks good. Add entry to RELEASE_NOTES.md and we can merge this. |
Contributor
|
@nojaf In this comment: #983 (comment) "/repo-assist" must be the first thing in the comment |
Contributor
|
/repo-assist looks good. Add entry to RELEASE_NOTES.md |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Commit pushed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist, an AI assistant for this repository.
Closes #885
Problem
In dark mode,
--header-borderwas#9b9b9b— a fairly light grey against the near-black backgroundrgb(20, 21, 26). This produced high-contrast, visually busy divider lines inconsistent with the subtle, low-contrast borders in light mode (#e8ecf1against white).Fix
Changed
--header-borderin[data-theme=dark]from#9b9b9bto#3a3a42. This is a dark grey that remains distinguishable from the background while matching the visual subtlety of the light-mode borders.Contrast comparison:
#e8ecf1on white — very subtle#9b9b9bon#14151a— high contrast (~6:1)#3a3a42on#14151a— subtle (~1.8:1), consistent with light mode feelTest Status
This is a CSS-only change with no F# code impact. No build or test failures expected. Visual verification needed by a maintainer with dark mode enabled.