Skip to content

Add check for fwd ref types#2

Closed
cristianbote wants to merge 1 commit intomasterfrom
add-check-for-forward-refs-types
Closed

Add check for fwd ref types#2
cristianbote wants to merge 1 commit intomasterfrom
add-check-for-forward-refs-types

Conversation

@cristianbote
Copy link
Copy Markdown
Member

This will make forwardRef(s) work with @frontity/react-easy-state and @frontity/with-preact.

@luisherranz
Copy link
Copy Markdown
Member

Hey Cris, as this library is React-agnostic, shouldn't we do this in view/connect?

Something like this:

const render = useMemo(
  () => {
    reaction.current = observe(isForwardRef ? Comp.render : Comp,
    // ...

@cristianbote
Copy link
Copy Markdown
Member Author

Hey Cris, as this library is React-agnostic, shouldn't we do this in view/connect?

Something like this:

const render = useMemo(
  () => {
    reaction.current = observe(isForwardRef ? Comp.render : Comp,
    // ...

Oh, right! Let me check.

@luisherranz
Copy link
Copy Markdown
Member

Any luck?

@cristianbote
Copy link
Copy Markdown
Member Author

Yeah this is not supposed to be fix in here for sure ✌️ closing and moving this to RES.

@cristianbote cristianbote deleted the add-check-for-forward-refs-types branch June 18, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants