Skip to content
This repository was archived by the owner on Feb 4, 2020. It is now read-only.

Add creation of Chocolatey and .zip packages with PyInstaller-generated clcache.exe#267

Merged
frerich merged 2 commits into
frerich:masterfrom
tadeu:add-pyinstaller-and-choco-package
Jan 28, 2017
Merged

Add creation of Chocolatey and .zip packages with PyInstaller-generated clcache.exe#267
frerich merged 2 commits into
frerich:masterfrom
tadeu:add-pyinstaller-and-choco-package

Conversation

@tadeu
Copy link
Copy Markdown
Contributor

@tadeu tadeu commented Jan 27, 2017

Trying to add the generation of these packages to this repository, as discussed in this PR #266

@tadeu tadeu force-pushed the add-pyinstaller-and-choco-package branch 2 times, most recently from 9dcc133 to a79288d Compare January 27, 2017 16:47
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 27, 2017

Current coverage is 89.42% (diff: 100%)

Merging #267 into master will not change coverage

@@             master       #267   diff @@
==========================================
  Files             1          1          
  Lines          1040       1040          
  Methods           0          0          
  Messages          0          0          
  Branches        166        166          
==========================================
  Hits            930        930          
  Misses           82         82          
  Partials         28         28          

Powered by Codecov. Last update 1e7b28a...b3ab6b4

@tadeu tadeu force-pushed the add-pyinstaller-and-choco-package branch 2 times, most recently from e21cc70 to 41746f5 Compare January 27, 2017 17:04
@tadeu tadeu force-pushed the add-pyinstaller-and-choco-package branch 2 times, most recently from c47a40a to 9eb1123 Compare January 27, 2017 17:22
@tadeu
Copy link
Copy Markdown
Contributor Author

tadeu commented Jan 27, 2017

@frerich Artifacts generation is working. :)

I think this would be useful to be merged as is, but later, from here, you might want to add a deploy section that will automatically add the artifacts to the GitHub releases (usually only for tagged builds), something like this, but I didn't research how to do the version part, or how to do only for tagged releases:

deploy:
  release: $(version)
  description: 'clcache $(version)'
  provider: GitHub
  auth_token:
    secure: <the github oauth key encrypted>
  artifact: clcache.$(version).nupkg,clcache-$(version).zip

@tadeu tadeu force-pushed the add-pyinstaller-and-choco-package branch from bcff6ed to 03c297f Compare January 27, 2017 17:53
@tadeu tadeu force-pushed the add-pyinstaller-and-choco-package branch from 03c297f to b3ab6b4 Compare January 27, 2017 18:00
@frerich
Copy link
Copy Markdown
Owner

frerich commented Jan 27, 2017

Great job, seems to work for me! Just one question (this may well be just me being ignorant about how to use Chocolatey, I'm still somewhat new to it):

I installed the clcache.4.0.0-dev.nupkg file by downloading it and then running (with Chocolatey v0.10.3):

choco install clcache -source "%CD%" -version 4.0.0-dev

Does that seem okay? It causes a warning message to be printed (but then proceeds to install the package):

C:\Users\Frerich\Desktop>cinst clcache -source %CD% -version 4.0.0-dev
Parsing -version resulted in error (converted to warning):
 Cannot bundle unregistered option '-e'.

Is the -dev part of the version number triggering this, i.e. choco expects a certain version number format? Or is this something caused by a defect when building the .nupkg file?
I'm not sure whether this

@tadeu
Copy link
Copy Markdown
Contributor Author

tadeu commented Jan 27, 2017 via email

@frerich frerich merged commit 3846bc9 into frerich:master Jan 28, 2017
@frerich
Copy link
Copy Markdown
Owner

frerich commented Jan 28, 2017

Merged, thanks a lot!

@tadeu tadeu deleted the add-pyinstaller-and-choco-package branch January 30, 2017 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants