Added base OS info to metadata endpoint #4059 #4077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushaldas
suggested changes
Jan 29, 2019
Contributor
kushaldas
left a comment
There was a problem hiding this comment.
@nightwarrior-xxx Please squash the commits into one. Also, add corresponding tests for this change.
Contributor
|
Hi @nightwarrior-xxx - in addition to the changes requested by @kushaldas above, can you update the PR to include a basic test plan for this feature change? It doesn't have to go into massive detail, just steps to verify the change and the expected values of the new variable would be fine. Thanks again for this! |
Contributor
|
hey @nightwarrior-xxx! would you like help with adding tests here? |
Contributor
Author
|
@redshiftzero Yup, sorry for being too late !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4059