This repository was archived by the owner on Jan 5, 2024. It is now read-only.
use latest pip-tools and update readme #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c85b28 to
38e0443
Compare
sssoleileraaa
commented
Aug 2, 2021
| # In any case, this callback mutates the given result object (in | ||
| # `res`) to include the name of the new file, or to indicate errors. | ||
| def on_save(self, fh: _TemporaryFileWrapper, res: Response) -> None: | ||
| def on_save(self, fh: IO[bytes], res: Response) -> None: |
Contributor
Author
There was a problem hiding this comment.
this was caught after updating linters
Contributor
Author
|
@kushaldas so far, i'm unable to repro the test failure that you're seeing (https://share.riseup.net/#2wYysshkw22s90YcyfRtVA) - will try a bit longer, but wanted to mention that it doesn't seem to be related to this PR since you are seeing the same error on main, so we might need to create an issue for this that we can follow up on. |
rmol
approved these changes
Aug 3, 2021
Contributor
rmol
left a comment
There was a problem hiding this comment.
👍 lgtm. Both make test and make check pass for me (if I tell safety to ignore the coverage alert, which is a known problem, not specific to this PR).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update dev dependencies, notably the mypy update required two new dev dependencies (
types-PyYAMLandtypes-requests) and a later version of black caught an incompatible type error (d556d67). This change also includes a readme and ci update to usemake venvinstead ofvirtualenv .venv --python=python3for instructions on how to create the virtual dev environment.Test Plan
make checkpasses