Open
Conversation
jwest115
approved these changes
Jan 29, 2026
Contributor
jwest115
left a comment
There was a problem hiding this comment.
Looks good to me, thank you! I added one minor comment to cpp_doc.py. Also, for the cpp doc tests, I noticed you used the unittest library. In the other tests I wrote for this tool I used pytest. There is probably a way for pytest to run unittest tests, but for the future we might want to choose one library for testing.
Comment on lines
+236
to
+237
| if __name__ == "__main__": | ||
| print("basic check") |
Contributor
There was a problem hiding this comment.
I think this could be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create Python module corresponding to the Scala package CppDoc.scala.